Fix button font weights #777
Conversation
🦋 Changeset detectedLatest commit: 18d8644 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -9,6 +9,7 @@ export const button = recipe({ | |||
| placeItems: "center", | |||
| padding: 0, | |||
| textDecoration: "none", | |||
| fontWeight: "bold", | |||
There was a problem hiding this comment.
suggestion: I'd be explicit here nad put 600 instead of bold.
There was a problem hiding this comment.
This one is mapped to token from theme (this is sprinkles context).
There was a problem hiding this comment.
also bold is actually 700 in the web API, perhaps it should be changed to semibold in sprinkles tokens
There was a problem hiding this comment.
I leave up to you - you will need to migrate Dashboard as well 🤔
|
Released snapshot build with Install it with: pnpm add @saleor/[email protected] |
I want to merge this change because it:
Screenshots
Pull Request Checklist
./src/components/index.ts.forwardRef.